comments

ifilonenko · ifilonenko · commit a28ebcf49334 · 2018-10-25T10:59:51.000-07:00
diff --git a/docs/running-on-kubernetes.md b/docs/running-on-kubernetes.md
@@ -45,7 +45,8 @@ logs and remains in "completed" state in the Kubernetes API until it's eventuall
 
 Note that in the completed state, the driver pod does *not* use any computational or memory resources.
 
-The driver and executor pod scheduling is handled by Kubernetes. It is possible to schedule the
+The driver and executor pod scheduling is handled by Kubernetes. Communication to the Kubernetes API is done via fabric8, and we are 
+currently running <code>kubernetes-client</code> version <code>4.1.0</code>. Make sure that any infrastructure additions are weary of said version. It is possible to schedule the
 driver and executor pods on a subset of available nodes through a [node selector](https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#nodeselector)
 using the configuration property for it. It will be possible to use more advanced
 scheduling hints like [node/pod affinities](https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity) in a future release.
diff --git a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
@@ -158,9 +158,7 @@ private[spark] object KubernetesUtils {
   }
 
   def formatTime(time: String): String = {
-    time match {
-      case null => "N/A"
-      case _ => time
-    }
+    // TODO: Investigate form `time` comes in
+    if (time != null) time else "N/A"
   }
 }
diff --git a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala
@@ -56,8 +56,7 @@ private[spark] class MountVolumesFeatureStep(
 
       val volumeBuilder = spec.volumeConf match {
         case KubernetesHostPathVolumeConf(hostPath) =>
-          // TODO: Backwards compatibility allows for empty string, but specify
-          // hostPath type here
+          /* "" means that no checks will be performed before mounting the hostPath volume */
           new VolumeBuilder()
             .withHostPath(new HostPathVolumeSource(hostPath, ""))
 

Original file line number	Diff line number	Diff line change
`@@ -158,9 +158,7 @@ private[spark] object KubernetesUtils {`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`def formatTime(time: String): String = {`
`161`		`- time match {`
`162`		`- case null => "N/A"`
`163`		`- case _ => time`
`164`		`- }`
	`161`	+ // TODO: Investigate form `time` comes in
	`162`	`+ if (time != null) time else "N/A"`
`165`	`163`	`}`
`166`	`164`	`}`