Addressing reviewers comments: unnecessary copy of data in predict

avulanov · avulanov · commit 9d18469b0e48 · 2015-07-24T08:22:33.000-07:00
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/ann/Layer.scala b/mllib/src/main/scala/org/apache/spark/mllib/ann/Layer.scala
@@ -599,7 +599,8 @@ class FeedForwardModel private(val layerModels: Array[LayerModel],
   }
 
   override def predict(data: Vector): Vector = {
-    val result = forward(data.toBreeze.toDenseVector.toDenseMatrix.t)
+    val size = data.size
+    val result = forward(new BDM[Double](size, 1, data.toArray))
     Vectors.dense(result.last.toArray)
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -599,7 +599,8 @@ class FeedForwardModel private(val layerModels: Array[LayerModel],`
`599`	`599`	`}`
`600`	`600`
`601`	`601`	`override def predict(data: Vector): Vector = {`
`602`		`- val result = forward(data.toBreeze.toDenseVector.toDenseMatrix.t)`
	`602`	`+ val size = data.size`
	`603`	`+ val result = forward(new BDM[Double](size, 1, data.toArray))`
`603`	`604`	`Vectors.dense(result.last.toArray)`
`604`	`605`	`}`
`605`	`606`	`}`