address pr comments

aray · aray · commit 9587bf1fc991 · 2017-08-01T16:03:59.000-05:00
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
@@ -64,8 +64,8 @@ private[sql] object JDBCRelation extends Logging {
       s"bound. Lower bound: $lowerBound; Upper bound: $upperBound")
 
     val numPartitions =
-      if ((upperBound - lowerBound) >= partitioning.numPartitions ||
-        (upperBound - lowerBound) < 0) {
+      if ((upperBound - lowerBound) >= partitioning.numPartitions || /* check for overflow */
+          (upperBound - lowerBound) < 0) {
         partitioning.numPartitions
       } else {
         logWarning("The number of partitions is reduced because the specified number of " +
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
@@ -389,7 +389,6 @@ class JDBCSuite extends SparkFunSuite
     val df = sql("SELECT * FROM partsoverflow")
     checkNumPartitions(df, expectedNumPartitions = 3)
     assert(df.collect().length == 3)
-
   }
 
   test("Register JDBC query with renamed fields") {

Original file line number	Diff line number	Diff line change
`@@ -389,7 +389,6 @@ class JDBCSuite extends SparkFunSuite`
`389`	`389`	`val df = sql("SELECT * FROM partsoverflow")`
`390`	`390`	`checkNumPartitions(df, expectedNumPartitions = 3)`
`391`	`391`	`assert(df.collect().length == 3)`
`392`		`-`
`393`	`392`	`}`
`394`	`393`
`395`	`394`	`test("Register JDBC query with renamed fields") {`