Remove null check

zsxwing · zsxwing · commit 90de09594195 · 2015-09-23T07:55:48.000+08:00
diff --git a/core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala b/core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
@@ -194,7 +194,7 @@ private[netty] class NettyRpcEnv(
 
               override def onSuccess(response: Array[Byte]): Unit = {
                 val reply = deserialize[AskResponse](response)
-                if (reply.reply != null && reply.reply.isInstanceOf[RpcFailure]) {
+                if (reply.reply.isInstanceOf[RpcFailure]) {
                   if (!promise.tryFailure(reply.reply.asInstanceOf[RpcFailure].e)) {
                     logWarning(s"Ignore failure: ${reply.reply}")
                   }

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ private[netty] class NettyRpcEnv(`
`194`	`194`
`195`	`195`	`override def onSuccess(response: Array[Byte]): Unit = {`
`196`	`196`	`val reply = deserialize[AskResponse](response)`
`197`		`- if (reply.reply != null && reply.reply.isInstanceOf[RpcFailure]) {`
	`197`	`+ if (reply.reply.isInstanceOf[RpcFailure]) {`
`198`	`198`	`if (!promise.tryFailure(reply.reply.asInstanceOf[RpcFailure].e)) {`
`199`	`199`	`logWarning(s"Ignore failure: ${reply.reply}")`
`200`	`200`	`}`