add test in DDLSuit

windpiger · windpiger · commit 8559e4e8f9b8 · 2017-02-24T13:55:43.000+08:00
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
@@ -440,7 +440,9 @@ case class DataSource(
 
           if (mode == SaveMode.Append) false
           else if (mode == SaveMode.Overwrite) true
-          else throw new IllegalStateException(s"unsupported save mode $mode")
+          else {
+            throw new IllegalStateException(s"unsupported save mode $mode")
+          }
         } else true
     }
 
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
@@ -1832,4 +1832,28 @@ class DDLSuite extends QueryTest with SharedSQLContext with BeforeAndAfterEach {
       }
     }
   }
+
+  test("CTAS for data source table with a created location") {
+    withTable("t") {
+      withTempDir {
+        dir =>
+          spark.sql(
+            s"""
+               |CREATE TABLE t
+               |USING parquet
+               |PARTITIONED BY(a, b)
+               |LOCATION '$dir'
+               |AS SELECT 3 as a, 4 as b, 1 as c, 2 as d
+             """.stripMargin)
+
+          val table = spark.sessionState.catalog.getTableMetadata(TableIdentifier("t"))
+          assert(table.location.stripSuffix("/") == dir.getAbsolutePath.stripSuffix("/"))
+
+          val partDir = new File(dir.getAbsolutePath + "/a=3")
+          assert(partDir.exists())
+
+          checkAnswer(spark.table("t"), Row(1, 2, 3, 4))
+      }
+    }
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -440,7 +440,9 @@ case class DataSource(`
`440`	`440`
`441`	`441`	`if (mode == SaveMode.Append) false`
`442`	`442`	`else if (mode == SaveMode.Overwrite) true`
`443`		`- else throw new IllegalStateException(s"unsupported save mode $mode")`
	`443`	`+ else {`
	`444`	`+ throw new IllegalStateException(s"unsupported save mode $mode")`
	`445`	`+ }`
`444`	`446`	`} else true`
`445`	`447`	`}`
`446`	`448`