address review comment

kiszk · kiszk · commit 83fef403b92a · 2017-11-17T14:36:42.000Z
diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
@@ -830,14 +830,31 @@ class CastSuite extends SparkFunSuite with ExpressionEvalHelper {
 
   test("SPARK-22500: cast for struct should not generate codes beyond 64KB") {
     val N = 1000
-    val from = new StructType(
+
+    val from1 = new StructType(
       (1 to N).map(i => StructField(s"s$i", StringType)).toArray)
-    val to = new StructType(
+    val to1 = new StructType(
       (1 to N).map(i => StructField(s"i$i", IntegerType)).toArray)
-
-    val input = Row.fromSeq((1 to N).map(i => i.toString))
-    val output = Row.fromSeq((1 to N))
-
-    checkEvaluation(cast(Literal.create(input, from), to), output)
+    val input1 = Row.fromSeq((1 to N).map(i => i.toString))
+    val output1 = Row.fromSeq((1 to N))
+    checkEvaluation(cast(Literal.create(input1, from1), to1), output1)
+
+    val from2 = new StructType(
+      (1 to N).map(i => StructField(s"a$i", ArrayType(StringType, containsNull = false))).toArray)
+    val to2 = new StructType(
+      (1 to N).map(i => StructField(s"i$i", ArrayType(IntegerType, containsNull = true))).toArray)
+    val input2 = Row.fromSeq((1 to N).map(_ => Seq("456", "true", "78.9")))
+    val output2 = Row.fromSeq((1 to N).map(_ => Seq(456, null, 78)))
+    checkEvaluation(cast(Literal.create(input2, from2), to2), output2)
+
+    val from3 = new StructType(
+      (1 to N).map(i => StructField(s"s$i",
+        StructType(Seq(StructField("l$i", IntegerType, nullable = true))))).toArray)
+    val to3 = new StructType(
+      (1 to N).map(i => StructField(s"s$i",
+        StructType(Seq(StructField("l$i", LongType, nullable = true))))).toArray)
+    val input3 = Row.fromSeq((1 to N).map(i => Row(i)))
+    val output3 = Row.fromSeq((1 to N).map(i => Row(i.toLong)))
+    checkEvaluation(cast(Literal.create(input3, from3), to3), output3)
   }
 }
