fix review findings

peter-toth · peter-toth · commit 6bccd84e9cdc · 2019-05-24T21:44:52.000+02:00
Change-Id: Ic4825dadecead44ffcda4dee9081fed75eb26a9e
diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantPropagationSuite.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantPropagationSuite.scala
@@ -39,7 +39,6 @@ class ConstantPropagationSuite extends PlanTest {
           ConstantPropagation,
           ConstantFolding,
           BooleanSimplification,
-          SimplifyBinaryComparison,
           PruneFilters) :: Nil
   }
 
@@ -159,7 +158,7 @@ class ConstantPropagationSuite extends PlanTest {
       .where(
         columnA === Literal(1) && columnA === Literal(2) && columnB === Add(columnA, Literal(3)))
 
-    val correctAnswer = testRelation.analyze
+    val correctAnswer = testRelation
 
     comparePlans(Optimize.execute(query.analyze), correctAnswer)
   }

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ class ConstantPropagationSuite extends PlanTest {`
`39`	`39`	`ConstantPropagation,`
`40`	`40`	`ConstantFolding,`
`41`	`41`	`BooleanSimplification,`
`42`		`- SimplifyBinaryComparison,`
`43`	`42`	`PruneFilters) :: Nil`
`44`	`43`	`}`
`45`	`44`
`@@ -159,7 +158,7 @@ class ConstantPropagationSuite extends PlanTest {`
`159`	`158`	`.where(`
`160`	`159`	`columnA === Literal(1) && columnA === Literal(2) && columnB === Add(columnA, Literal(3)))`
`161`	`160`
`162`		`- val correctAnswer = testRelation.analyze`
	`161`	`+ val correctAnswer = testRelation`
`163`	`162`
`164`	`163`	`comparePlans(Optimize.execute(query.analyze), correctAnswer)`
`165`	`164`	`}`