address review comment

kiszk · kiszk · commit 626548187ca2 · 2019-04-07T08:17:49.000+09:00
diff --git a/core/src/main/scala/org/apache/spark/util/SizeEstimator.scala b/core/src/main/scala/org/apache/spark/util/SizeEstimator.scala
@@ -132,8 +132,8 @@ object SizeEstimator extends Logging {
     }
 
     // java.vm.info provides compressed ref info for IBM and OpenJ9 JDKs
-    if (System.getProperty("java.vendor").contains("IBM") ||
-        System.getProperty("java.vendor").contains("OpenJ9")) {
+    val javaVendor = System.getProperty("java.vendor")
+    if (javaVendor.contains("IBM") || javaVendor.contains("OpenJ9")) {
       return System.getProperty("java.vm.info").contains("Compressed Ref")
     }
 

Original file line number	Diff line number	Diff line change
`@@ -132,8 +132,8 @@ object SizeEstimator extends Logging {`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`// java.vm.info provides compressed ref info for IBM and OpenJ9 JDKs`
`135`		`- if (System.getProperty("java.vendor").contains("IBM") \|\|`
`136`		`- System.getProperty("java.vendor").contains("OpenJ9")) {`
	`135`	`+ val javaVendor = System.getProperty("java.vendor")`
	`136`	`+ if (javaVendor.contains("IBM") \|\| javaVendor.contains("OpenJ9")) {`
`137`	`137`	`return System.getProperty("java.vm.info").contains("Compressed Ref")`
`138`	`138`	`}`
`139`	`139`