Skip to content

Commit 5601d16

Browse files
author
Marcelo Vanzin
committed
Remove obsolete test.
1 parent 91765ab commit 5601d16

File tree

1 file changed

+6
-17
lines changed

1 file changed

+6
-17
lines changed

resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStepSuite.scala

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,10 @@ class DriverCommandFeatureStepSuite extends SparkFunSuite {
2929

3030
private val MAIN_CLASS = "mainClass"
3131

32-
test("no resource defined runs java driver") {
33-
val spec = applyFeatureStep(appArgs = Array("5 7"))
34-
val container = spec.pod.container
35-
assert(spec.pod.container.getArgs.asScala === List(
36-
"driver",
37-
"--properties-file", SPARK_CONF_PATH,
38-
"--class", MAIN_CLASS,
39-
"spark-internal", "5 7"))
40-
assert(spec.systemProperties.isEmpty)
41-
}
42-
4332
test("java resource") {
4433
val mainResource = "local:///main.jar"
4534
val spec = applyFeatureStep(
46-
resource = JavaMainAppResource(Some(mainResource)),
35+
JavaMainAppResource(Some(mainResource)),
4736
appArgs = Array("5", "7"))
4837
assert(spec.pod.container.getArgs.asScala === List(
4938
"driver",
@@ -61,8 +50,8 @@ class DriverCommandFeatureStepSuite extends SparkFunSuite {
6150
.set(PYSPARK_MAJOR_PYTHON_VERSION, "3")
6251

6352
val spec = applyFeatureStep(
64-
conf = sparkConf,
65-
resource = PythonMainAppResource(mainResource))
53+
PythonMainAppResource(mainResource),
54+
conf = sparkConf)
6655
assert(spec.pod.container.getArgs.asScala === List(
6756
"driver",
6857
"--properties-file", SPARK_CONF_PATH,
@@ -89,8 +78,8 @@ class DriverCommandFeatureStepSuite extends SparkFunSuite {
8978
.set("spark.files", filesInConf.mkString(","))
9079
.set(PYSPARK_MAJOR_PYTHON_VERSION, "2")
9180
val spec = applyFeatureStep(
81+
PythonMainAppResource(mainResource),
9282
conf = sparkConf,
93-
resource = PythonMainAppResource(mainResource),
9483
appArgs = Array("5", "7", "9"),
9584
pyFiles = pyFiles)
9685

@@ -117,7 +106,7 @@ class DriverCommandFeatureStepSuite extends SparkFunSuite {
117106
val mainResource = s"local://$expectedMainResource"
118107

119108
val spec = applyFeatureStep(
120-
resource = RMainAppResource(mainResource),
109+
RMainAppResource(mainResource),
121110
appArgs = Array("5", "7", "9"))
122111

123112
assert(spec.pod.container.getArgs.asScala === List(
@@ -128,8 +117,8 @@ class DriverCommandFeatureStepSuite extends SparkFunSuite {
128117
}
129118

130119
private def applyFeatureStep(
120+
resource: MainAppResource,
131121
conf: SparkConf = new SparkConf(false),
132-
resource: MainAppResource = JavaMainAppResource(None),
133122
appArgs: Array[String] = Array(),
134123
pyFiles: Seq[String] = Nil): KubernetesDriverSpec = {
135124
val driverConf = new KubernetesDriverSpecificConf(

0 commit comments

Comments
 (0)