Optimize the lock in StreamingJobProgressListener to not block UI when generating Streaming jobs

uncleGen · uncleGen · commit 46036bf68363 · 2017-01-16T17:14:32.000+08:00
diff --git a/streaming/src/main/scala/org/apache/spark/streaming/DStreamGraph.scala b/streaming/src/main/scala/org/apache/spark/streaming/DStreamGraph.scala
@@ -112,12 +112,10 @@ final private[streaming] class DStreamGraph extends Serializable with Logging {
 
   def generateJobs(time: Time): Seq[Job] = {
     logDebug("Generating jobs for time " + time)
-    val jobs = this.synchronized {
-      outputStreams.flatMap { outputStream =>
-        val jobOption = outputStream.generateJob(time)
-        jobOption.foreach(_.setCallSite(outputStream.creationSite))
-        jobOption
-      }
+    val jobs = getOutputStreams().flatMap { outputStream =>
+      val jobOption = outputStream.generateJob(time)
+      jobOption.foreach(_.setCallSite(outputStream.creationSite))
+      jobOption
     }
     logDebug("Generated " + jobs.length + " jobs for time " + time)
     jobs
