address comments

clockfly · clockfly · commit 1965b1a91863 · 2016-08-31T07:26:53.000+08:00
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
@@ -39,7 +39,7 @@ import org.apache.spark.sql.types._
  *
  * @param child child expression that can produce column value with `child.eval(inputRow)`
  * @param percentageExpression Expression that represents a single percentage value or
- *                             a array of percentage values. Each percentage value must be between
+ *                             an array of percentage values. Each percentage value must be between
  *                             0.0 and 1.0.
  * @param accuracyExpression Integer literal expression of approximation accuracy. Higher value
  *                           yields better accuracy, the default value is
diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentileSuite.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentileSuite.scala
@@ -170,7 +170,7 @@ class ApproximatePercentileSuite extends SparkFunSuite {
     val defaultAccuracy = ApproximatePercentile.DEFAULT_PERCENTILE_ACCURACY
     // sql, single percentile
     assertEqual(
-      "percentile_approx(`a`, 0.5D, 1000)",
+      s"percentile_approx(`a`, 0.5D, $defaultAccuracy)",
       new ApproximatePercentile("a".attr, percentageExpression = Literal(0.5D)).sql: String)
 
     // sql, array of percentile
@@ -183,7 +183,7 @@ class ApproximatePercentileSuite extends SparkFunSuite {
 
     // sql(isDistinct = false), single percentile
     assertEqual(
-      "percentile_approx(`a`, 0.5D, 1000)",
+      s"percentile_approx(`a`, 0.5D, $defaultAccuracy)",
       new ApproximatePercentile("a".attr, percentageExpression = Literal(0.5D))
         .sql(isDistinct = false))
 
@@ -197,7 +197,7 @@ class ApproximatePercentileSuite extends SparkFunSuite {
 
     // sql(isDistinct = true), single percentile
     assertEqual(
-      "percentile_approx(DISTINCT `a`, 0.5D, 1000)",
+      s"percentile_approx(DISTINCT `a`, 0.5D, $defaultAccuracy)",
       new ApproximatePercentile("a".attr, percentageExpression = Literal(0.5D))
         .sql(isDistinct = true))
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ import org.apache.spark.sql.types._`
`39`	`39`	`*`
`40`	`40`	* @param child child expression that can produce column value with `child.eval(inputRow)`
`41`	`41`	`* @param percentageExpression Expression that represents a single percentage value or`
`42`		`- * a array of percentage values. Each percentage value must be between`
	`42`	`+ * an array of percentage values. Each percentage value must be between`
`43`	`43`	`* 0.0 and 1.0.`
`44`	`44`	`* @param accuracyExpression Integer literal expression of approximation accuracy. Higher value`
`45`	`45`	`* yields better accuracy, the default value is`