Skip to content

Commit 1252d08

Browse files
committed
new pylint ignore after rebase
+ quiet mode for sphinx
1 parent cd7184a commit 1252d08

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

dev/lint-python

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,11 @@ cd "$SPARK_ROOT_DIR"
5252
DEBUG=false
5353
PIP_ARG="-q"
5454
VIRTUALENV_ARG="-q"
55+
SPHINX_ARGS="-q"
5556
if [[ $1 == "--debug" || $1 == "-d" ]]; then
5657
DEBUG=true
5758
PIP_ARG=""
59+
SPHINX_ARGS=""
5860
VIRTUALENV_ARG=""
5961
fi
6062

@@ -135,13 +137,13 @@ if hash "$SPHINXBUILD" 2> /dev/null; then
135137
echo "Building docs..."
136138
make clean
137139
# Treat warnings as errors so we stop correctly
138-
SPHINXOPTS="-a -W" make html &> "$SPHINX_REPORT_PATH" || lint_status=1
140+
SPHINXOPTS="-a -W $SPHINX_ARGS" make html &> "$SPHINX_REPORT_PATH" || lint_status=1
139141
if [ "$lint_status" -ne 0 ]; then
140142
echo "pydoc checks failed."
141143
cat "$SPHINX_REPORT_PATH"
142144
echo "re-running make html to print full warning list"
143145
make clean
144-
SPHINXOPTS="-a" make html
146+
SPHINXOPTS="-a $SPHINX_ARGS" make html
145147
rm "$SPHINX_REPORT_PATH"
146148
exit "$lint_status"
147149
else

python/pylintrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ disable=
101101
cyclic-import,
102102
dangerous-default-value,
103103
deprecated-lambda,
104+
deprecated-method,
104105
duplicate-code,
105106
eval-used,
106107
exec-used,
@@ -154,10 +155,12 @@ disable=
154155
unnecessary-pass,
155156
unneeded-not,
156157
unpacking-non-sequence,
158+
unsubscriptable-object,
157159
unused-argument,
158160
unused-import,
159161
unused-variable,
160162
unused-wildcard-import,
163+
used-before-assignment,
161164
useless-else-on-loop,
162165
wildcard-import,
163166
wrong-import-order,

0 commit comments

Comments
 (0)