More comment.

viirya · viirya · commit 0bb8c0ec7024 · 2017-08-13T10:57:45.000Z
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
@@ -152,6 +152,12 @@ trait CodegenSupport extends SparkPlan {
 
     // Under certain conditions, we can put the logic to consume the rows of this operator into
     // another function. So we can prevent a generated function too long to be optimized by JIT.
+    // The conditions:
+    // 1. The parent uses all variables in output. we can't defer variable evaluation when consume
+    //    in another function.
+    // 2. The output variables are not empty. If it's empty, we don't bother to do that.
+    // 3. We don't use row variable. The construction of row uses deferred variable evaluation. We
+    //    can't do it.
     val requireAllOutput = output.forall(parent.usedInputs.contains(_))
     val consumeFunc =
       if (row == null && outputVars.nonEmpty && requireAllOutput) {
