Skip to content

Commit 06efcac

Browse files
author
jinxing
committed
[SPARK-19437] Rectify spark executor id in HeartbeatReceiverSuite.
1 parent b098576 commit 06efcac

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ class HeartbeatReceiverSuite
4646
with PrivateMethodTester
4747
with LocalSparkContext {
4848

49-
private val executorId1 = "executor-1"
50-
private val executorId2 = "executor-2"
49+
private val executorId1 = "1"
50+
private val executorId2 = "2"
5151

5252
// Shared state that must be reset before and after each test
5353
private var scheduler: TaskSchedulerImpl = null
@@ -173,11 +173,11 @@ class HeartbeatReceiverSuite
173173
val dummyExecutorEndpoint2 = new FakeExecutorEndpoint(rpcEnv)
174174
val dummyExecutorEndpointRef1 = rpcEnv.setupEndpoint("fake-executor-1", dummyExecutorEndpoint1)
175175
val dummyExecutorEndpointRef2 = rpcEnv.setupEndpoint("fake-executor-2", dummyExecutorEndpoint2)
176-
fakeSchedulerBackend.driverEndpoint.askWithRetry[Boolean](
176+
fakeSchedulerBackend.driverEndpoint.askSync[Boolean](
177177
RegisterExecutor(executorId1, dummyExecutorEndpointRef1, "1.2.3.4", 0, Map.empty))
178-
fakeSchedulerBackend.driverEndpoint.askWithRetry[Boolean](
178+
fakeSchedulerBackend.driverEndpoint.askSync[Boolean](
179179
RegisterExecutor(executorId2, dummyExecutorEndpointRef2, "1.2.3.5", 0, Map.empty))
180-
heartbeatReceiverRef.askWithRetry[Boolean](TaskSchedulerIsSet)
180+
heartbeatReceiverRef.askSync[Boolean](TaskSchedulerIsSet)
181181
addExecutorAndVerify(executorId1)
182182
addExecutorAndVerify(executorId2)
183183
triggerHeartbeat(executorId1, executorShouldReregister = false)
@@ -195,7 +195,7 @@ class HeartbeatReceiverSuite
195195
// Here we use a timeout of O(seconds), but in practice this whole test takes O(10ms).
196196
val executorTimeout = heartbeatReceiver.invokePrivate(_executorTimeoutMs())
197197
heartbeatReceiverClock.advance(executorTimeout * 2)
198-
heartbeatReceiverRef.askWithRetry[Boolean](ExpireDeadHosts)
198+
heartbeatReceiverRef.askSync[Boolean](ExpireDeadHosts)
199199
val killThread = heartbeatReceiver.invokePrivate(_killExecutorThread())
200200
killThread.shutdown() // needed for awaitTermination
201201
killThread.awaitTermination(10L, TimeUnit.SECONDS)

0 commit comments

Comments
 (0)