Make PodDisruptionBudget an optional feature #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoustonPutman
changed the title
Contributor
|
Taking a look at this now as a way to brush up on operator code. Thanks for all the work you put into documenting this Houston! |
This commit adds the necessary logic during solrcloud reconciliation to obey the enable/disable flag for PDB creation.A Still needed is integration with the solrcloud helm chart.
Contributor
|
Alright, should be ready for review. Lmk if I missed anything! |
HoustonPutman
commented
Apr 7, 2023
Contributor
Author
HoustonPutman
left a comment
HoustonPutman
left a comment
There was a problem hiding this comment.
Looks great!
A few hopefully quick changes, but overall great!
| return requeueOrNot, err | ||
| } | ||
| } else { // PDB is disabled, make sure that we delete any previously created pdb that might exist. | ||
| err = r.Client.Delete(ctx, pdb) |
Contributor
Author
There was a problem hiding this comment.
Interesting... So it's basically as good to delete something that might not exist as it is to check if it exists first before deleting it.
Co-authored-by: Houston Putman <[email protected]>
HoustonPutman
commented
Apr 10, 2023
Contributor
Author
HoustonPutman
left a comment
HoustonPutman
left a comment
There was a problem hiding this comment.
Looks good to me!!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #538
List to do: