Skip to content

Use correct user for chmod command in cp-solr-xml init container #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HoustonPutman merged 10 commits into from
Apr 19, 2023
Merged

Use correct user for chmod command in cp-solr-xml init container #520

HoustonPutman merged 10 commits into from
Apr 19, 2023

Conversation

@a-nych
Copy link
Contributor

@a-nych a-nych commented Jan 23, 2023

Resolves #519.

@a-nych a-nych force-pushed the fix/chmod_user_group branch from cd5e897 to 12213dd Compare January 23, 2023 11:00
@a-nych a-nych changed the title Use correct user for chmod command in cp-solr-xml init container Draft: Use correct user for chmod command in cp-solr-xml init container Jan 23, 2023
@a-nych a-nych changed the title Draft: Use correct user for chmod command in cp-solr-xml init container Use correct user for chmod command in cp-solr-xml init container Jan 23, 2023
HoustonPutman
HoustonPutman reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I have a general question about this. We only specify the fsGroup by default. Do we not want to use the fsGroup provided in the custom PodSecurityContext?

HoustonPutman
HoustonPutman reviewed Jan 23, 2023
View reviewed changes
@HoustonPutman
Copy link
Contributor

HoustonPutman commented Mar 7, 2023

@a-nych I'm pushing for a v0.7.0 release soon and it would be great to get this in there. Do you have any more info for my runAsUser vs runAsGroup question?

@HoustonPutman
Copy link
Contributor

HoustonPutman commented Apr 12, 2023

@a-nych pinging again so that we can get this in the upcoming release

@HoustonPutman
Copy link
Contributor

HoustonPutman commented Apr 17, 2023

So I have a general question about this. We only specify the fsGroup by default. Do we not want to use the fsGroup provided in the custom PodSecurityContext?

We do want to use the fsGroup, since that is what is used for volumes. I am also making sure to use 8983 as the default fsGroup when a custom podSecurityContext is provided that doesn't use an fsGroup.

@a-nych
Copy link
Contributor Author

a-nych commented Apr 17, 2023 via email

@HoustonPutman
Copy link
Contributor

HoustonPutman commented Apr 17, 2023

Thanks @a-nych , I'm planning on trying to cut the release by early afternoon tomorrow (EST timezone), so if you could get your review in early that'd be great!

a-nych
a-nych commented Apr 18, 2023
View reviewed changes
@HoustonPutman
Copy link
Contributor

HoustonPutman commented Apr 18, 2023

Had to include some fixes for #548 and #537 since the E2E tests wouldn't work without the fixes.

This should be good to go though, it's been thoroughly tested using the E2E testing framework.

@HoustonPutman HoustonPutman merged commit cc710af into apache:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HoustonPutman HoustonPutman HoustonPutman left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cp-solr-xml fails when a local backup repository is configured with SolrCloud running as a custom user

2 participants

@a-nych @HoustonPutman