Fix SolrBackup not taking backups when the collections field is omitted #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoustonPutman
approved these changes
Jan 17, 2023
a-nych
changed the title
Contributor
Author
|
@HoustonPutman Thanks for the feedback! I've added the changelog. Do we want to wait for #507 before merging this? |
Contributor
|
This looks good to me! We can merge this before the e2e tests, and add a test for it after that is merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #515.
When there are no collections specified in the CRD, attempt to list them all from SolrCloud and back them up.