Add Annotations to created ServiceAccount #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HoustonPutman
left a comment
HoustonPutman
left a comment
There was a problem hiding this comment.
This looks good to me.
Could you add a changelog entry in the Chart.yaml, and add it to the list of available options in the chart's README?
This is also something that we could add to the solr-operator chart.
In order to support AWS IAM Role assumption via the [pod-identity-webhook](https://github.com/aws/amazon-eks-pod-identity-webhook), there need to be annotations added to the ServiceAccount.
endzyme
force-pushed
the
add-annotations-to-solr-service-account
branch
from
024a991 to
f152054
Compare
Contributor
Author
|
@HoustonPutman I've updated the changelog and added the same feature to the solr-operator chart. |
Closed
Contributor
|
Made a fix for the serviceAccount when annotations are not provided, but otherwise should be good to go! This will make it into |
HoustonPutman
added
custom kube options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support AWS IAM Role assumption via the pod-identity-webhook, there need to be annotations added to the ServiceAccount.
This change enables users to add annotations to the ServiceAccount created for the SolrCloud instance.