Add a podDisruptionBudget for the whole cloud #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you so much @HoustonPutman for this - Is there any way to avoid creating a PDB via the operator? |
Contributor
Author
|
No there is not currently. @endzyme would you mind creating a ticket for that? Should be pretty easy to implement if you also want to take a stab at it 🙂 |
Contributor
Author
|
Note, this request was taken care of in #540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #471
I also had to upgrade the Kubernetes libraries in go to 1.21, in order to get the v1 version of the
PodDisruptionBudget.That is why there are so many documentation changes in the CRDs.
I have included a method to generate PDBs for shards, but it is unused given the current restraints in Kubernetes that do not allow us to map multiple PDBs to a single pod. This limitation is documented with the unused method. Hopefully we can use it in the future.
Still need: