Recompute NextScheduled backup on each reconcile #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the 'NextScheduled' field of a solrbackup's status was never updated, even if the user the backup schedule in the solrbackup spec. This commit changes this: NextScheduled is now recomputed during each reconciliation, as long as there is not an active backup ongoing.
Contributor
|
We were discussing offline about how the schedule gets restarted if the user disables the recurrence and then re-enables it. Does this fix that? |
HoustonPutman
approved these changes
Jul 8, 2022
Contributor
HoustonPutman
left a comment
HoustonPutman
left a comment
There was a problem hiding this comment.
Otherwise this looks simple and straightforward, LGTM!
Contributor
Author
This fixes that "problem", yep. Prior to this PR, a backup would immediately be run upon re-enabling the |
gerlowskija
deleted the
376_recompute_nextscheduled_backup_on_each_reconcile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #376
Prior to this commit, the 'NextScheduled' field of a solrbackup's status
was never updated, even if the user the backup schedule in the
solrbackup spec.
This commit changes this: NextScheduled is now recomputed during each
reconciliation, as long as there is not an active backup ongoing.