Allow for managed restarts across multiple SolrCloud resources. #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@joel-bernstein, could you build this locally and try it out with your setup? The unit tests are pretty comprehensive, but it would be good to have some live testing as well! |
Contributor
Author
|
(if you can't change the CRDs in your setup, you might want to backport this to |
Contributor
Author
|
I tested locally and this works well for me. Will merge in a few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #348
This is a change to improve the logic of the managed upgrades, so that the solr operator does not assume that a cloud is completely managed by one SolrCloud resource.
Instead of making sure that
# of desired pods=# of live nodesbefore upgrading the overseer, the operator now just makes sure that all pod names that it manages are accounted for in the cluster's live nodes. This allows for running multiple SolrCloud resources that connect together, while still using the managed restart functionality.Note this is a fairly small change, but required a lot of refactoring in the tests. That is mostly noise.