Support custom Lifecycle for Solr & PrometheusExporter containers #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoustonPutman
requested changes
Sep 23, 2021
Contributor
HoustonPutman
left a comment
HoustonPutman
left a comment
There was a problem hiding this comment.
This looks good to me! But I would like to see a test added 🙂
Great contribution 🎉
HoustonPutman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #322
Describe your changes
This PR adds support for custom Lifecycle input for Solr main container. A user should be able to set
lifecycle.preStopandlifecycle.postStarthooks through SolrCloud CR for Solr main container.This PR also includes Helm chart changes to support lifecycle inputs.
Tested locally on minikube.