Upgrade to use Kubebuilder 3 #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still undone: - Adding tests - Fixing the mess with the Zookeeper Operator - Making the manifests generation work with Helm - Update the Solr Operator Helm chart to support the new stuff - Figure out if we need to use the new Controller config stuff
…hing to the Prometheus Exporter.
- Also fixed issue with defaulting ports with TLS enabled
… Add all related changelog entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #320
This is a major ticket with a large footprint, but hopefully the end result will function as closely to the current Solr Operator repo as possible.
Instead of tossing out all new Kubebuilder features and standards and stick with the familiar things that work, we will try to modernize the way we use Kubebuilder to match the Kubebuilder 3 standards.
This way we won't put modernizing on the back-burner and end up not doing it down the line.
Current known list of issues:
We might not be able to keep our Zookeeper Operator golang dependency, which will require significant work in the zk reconciling. This is because the Zookeeper Operator is using outdated libraries that conflict with the libraries required in Kubebuilder 3.