Skip to content

Conversation

@HoustonPutman
Copy link
Contributor

@HoustonPutman HoustonPutman commented Jul 6, 2021

Resolves #281

@HoustonPutman HoustonPutman requested a review from thelabdude July 6, 2021 20:42
@thelabdude
Copy link
Contributor

haven't reviewed yet, just wondering if a Go duration string (https://golang.org/pkg/time/#ParseDuration) would work better than a CRON string? Similar to the pod reaper https://github.com/ptagr/pod-reaper ...

@HoustonPutman
Copy link
Contributor Author

Conveniently this CRON api supports @every <duration>!

Copy link
Contributor

@thelabdude thelabdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice unit tests!

@HoustonPutman HoustonPutman linked an issue Jul 8, 2021 that may be closed by this pull request
@HoustonPutman HoustonPutman merged commit 36a6207 into apache:main Jul 8, 2021
@HoustonPutman HoustonPutman deleted the scheduled-restarts branch July 8, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable scheduled restarts of Solr Clouds

2 participants