Skip to content

Add license and let it could automatically generate#13

Closed
mrproliu wants to merge 5 commits intoapache:mainfrom
mrproliu:dependency-license
Closed

Add license and let it could automatically generate#13
mrproliu wants to merge 5 commits intoapache:mainfrom
mrproliu:dependency-license

Conversation

@mrproliu
Copy link
Copy Markdown
Contributor

  1. update the dependency licenses
  2. integrate with skywalking-eyes, let it could generate the license automatically.
  3. Add to the CI, so it can check the dependency license in each PR.

@kezhenxu94 Please help to check the license generate code, there have some duplicated codes with eyes, not all of them. Maybe we could let the eyes generate it?

@mrproliu mrproliu added the enhancement New feature or request label Apr 13, 2022
@mrproliu mrproliu added this to the 0.1.0 milestone Apr 13, 2022
@mrproliu mrproliu requested review from kezhenxu94 and wu-sheng April 13, 2022 16:03
@mrproliu mrproliu changed the title Add license and Let it could automatically generate Add license and let it could automatically generate Apr 13, 2022
@wu-sheng
Copy link
Copy Markdown
Member

@kezhenxu94 @mrproliu We may need to discuss whether is generating license reasonable, and what should be the policy.

Should we open a discussion separate in main repo about this before take any action?

@mrproliu
Copy link
Copy Markdown
Contributor Author

Should we open a discussion separate in main repo about this before take any action?

Sure. In my case, It could help me quickly generate the licenses file, and reduce the number of steps in the release process.

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented May 7, 2022

Should we close this?

@mrproliu
Copy link
Copy Markdown
Contributor Author

mrproliu commented May 7, 2022

Yes. closed.

@mrproliu mrproliu closed this May 7, 2022
@mrproliu mrproliu deleted the dependency-license branch May 7, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants