Conversation
This template follows Mozilla's official guidance, located at https://www.mozilla.org/en-US/MPL/headers/
|
I have assigned the reviewer, but he has some personal stuff for 2 weeks. So this PR will be pending a little longer than usual.Please wait. |
| This Source Code Form is subject to the terms of the Mozilla Public | ||
| License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| file, You can obtain one at https://mozilla.org/MPL/2.0/. |
There was a problem hiding this comment.
I can confirm the content of this header matches the official version, https://www.mozilla.org/en-US/MPL/headers/
|
Putting The current test has not considered other headers except In order to support other headers, maybe you should modify it and add some test data in |
|
Thank you @steveklabnik for opening this PR and @MoGuGuai-hzr for reviewing!!! The changes looks good to me. As for the tests, now we just want to test the mechanism that finding license header and comparing the header works, adding tests for each license might be boring and duplicating so I don't require (nor reject) it if anyone would like to add. |
4 participants
Hi there, thanks for this great project! I am using the MPL in some places, and so would love built-in support for it. It's really nice that it was so easy to use a
contentblock to get started, but I figured upstreaming this would be nice :)I am not sure if I should be adding a test or anything, happy to make any modifications you'd like. I did verify that this works by running my branch against a sample codebase, you can see that result here: https://github.com/steveklabnik/ci-license-test/pull/4