Skip to content

Speed up the initialization phase#75

Merged
kezhenxu94 merged 1 commit intomainfrom
perf/init-templates
Oct 2, 2021
Merged

Speed up the initialization phase#75
kezhenxu94 merged 1 commit intomainfrom
perf/init-templates

Conversation

@kezhenxu94
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 commented Oct 2, 2021 •
edited
Loading

We have many license template files to load at initialization phase, this speeds up the initialization phase from 8s to 2s

pwd                                                        
/Users/kezhenxu94/workspace/skywalking-infra-e2e

Before

time ~/workspace/skywalking-eyes/bin/darwin/license-eye h c
INFO GITHUB_TOKEN is not set, license-eye won't comment on the pull request 
INFO Loading configuration from file: .licenserc.yaml 
INFO Totally checked 2336 files, valid: 59, invalid: 0, ignored: 2277, fixed: 0 

================
CPU	108%
user	8.451
system	0.351
total	8.146

time ~/workspace/skywalking-eyes/bin/darwin/license-eye h c
INFO GITHUB_TOKEN is not set, license-eye won't comment on the pull request 
INFO Loading configuration from file: .licenserc.yaml 
INFO Totally checked 2336 files, valid: 59, invalid: 0, ignored: 2277, fixed: 0 

================
CPU	107%
user	8.380
system	0.337
total	8.086

time ~/workspace/skywalking-eyes/bin/darwin/license-eye h c
INFO GITHUB_TOKEN is not set, license-eye won't comment on the pull request 
INFO Loading configuration from file: .licenserc.yaml 
INFO Totally checked 2336 files, valid: 59, invalid: 0, ignored: 2277, fixed: 0 

================
CPU	107%
user	8.921
system	0.357
total	8.661

After

time ~/workspace/skywalking-eyes/bin/darwin/license-eye h c
INFO GITHUB_TOKEN is not set, license-eye won't comment on the pull request 
INFO Loading configuration from file: .licenserc.yaml 
INFO Totally checked 2336 files, valid: 59, invalid: 0, ignored: 2277, fixed: 0 

================
CPU	927%
user	17.638
system	0.511
total	1.957

time ~/workspace/skywalking-eyes/bin/darwin/license-eye h c
INFO GITHUB_TOKEN is not set, license-eye won't comment on the pull request 
INFO Loading configuration from file: .licenserc.yaml 
INFO Totally checked 2336 files, valid: 59, invalid: 0, ignored: 2277, fixed: 0 

================
CPU	1076%
user	18.164
system	0.517
total	1.736

time ~/workspace/skywalking-eyes/bin/darwin/license-eye h c
INFO GITHUB_TOKEN is not set, license-eye won't comment on the pull request 
INFO Loading configuration from file: .licenserc.yaml 
INFO Totally checked 2336 files, valid: 59, invalid: 0, ignored: 2277, fixed: 0 

================
CPU	994%
user	17.888
system	0.492
total	1.847

@kezhenxu94 kezhenxu94 added the enhancement New feature or request label Oct 2, 2021
@kezhenxu94 kezhenxu94 added this to the 0.2.0 milestone Oct 2, 2021
@kezhenxu94 kezhenxu94 requested review from fgksgf and wu-sheng October 2, 2021 03:24
@kezhenxu94 kezhenxu94 merged commit bcdd6bc into main Oct 2, 2021
@kezhenxu94 kezhenxu94 deleted the perf/init-templates branch October 2, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgksgf fgksgf fgksgf approved these changes

@wu-sheng wu-sheng Awaiting requested review from wu-sheng

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kezhenxu94 @fgksgf