fix some program compatibility issues in Windows#44
Merged
kezhenxu94 merged 1 commit intoapache:mainfrom Jul 16, 2021
zooltd:main
Merged
fix some program compatibility issues in Windows#44kezhenxu94 merged 1 commit intoapache:mainfrom zooltd:main
kezhenxu94 merged 1 commit intoapache:mainfrom
zooltd:main
Conversation
kezhenxu94
approved these changes
Jul 16, 2021
Member
kezhenxu94
left a comment
kezhenxu94
left a comment
There was a problem hiding this comment.
Nice catch! We might also consider adding Windows to the CI test matrices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embeded file system
embed.FSonly takes the forward slash (/) as the path separator. However, the operating system path separator in Windows is the backward slash (\). We need to normalize the file path separator each time we useembed.FS.