Skip to content

Fix optional dependencies are not excluded#136

Merged
kezhenxu94 merged 1 commit intomainfrom
maven/optional
Sep 7, 2022
Merged

Fix optional dependencies are not excluded#136
kezhenxu94 merged 1 commit intomainfrom
maven/optional

Conversation

@kezhenxu94
Copy link
Copy Markdown
Member

Optional dependencies should be excluded but they are not because of regexp missing the optional part

[INFO] +- org.mariadb.jdbc:mariadb-java-client:jar:2.7.2:provided (optional) 

@kezhenxu94 kezhenxu94 added bug Something isn't working dep / maven Dependency command, maven project labels Sep 7, 2022
@kezhenxu94 kezhenxu94 added this to the 0.5.0 milestone Sep 7, 2022
@kezhenxu94 kezhenxu94 merged commit 25edfc2 into main Sep 7, 2022
@kezhenxu94 kezhenxu94 deleted the maven/optional branch September 7, 2022 15:06
@slievrly
Copy link
Copy Markdown
Member

slievrly commented Sep 8, 2022

@kezhenxu94 get the latest code, make build, and the test case passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dep / maven Dependency command, maven project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants