Skip to content

Add “.exe” suffix to the Windows compiled executable program for skywalking-eyes #7845

@kezhenxu94

Description

@kezhenxu94

Discussed in #7844

Originally posted by codeglzhang September 30, 2021
In skywalking-infra-e2e, we can use make build to get a Windows executable program skywalking-eyes\bin\windows\license-eye. However, in the command line of Windows, whether the file is an executable program is determined by whether the file has a specific suffix, such as ".exe". Thus, commands such as bin/darwin/license-eye -c test/testdata/.licenserc_for_test_fix.yaml header check will not be executed correctly under Windows.
image
After renaming the file skywalking-eyes\bin\windows\license-eye to skywalking-eyes\bin\windows\license-eye.exe, the command is executed.
image
The same is true for skywalking-infra-e2e.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working and you are sure it's a bug!license eye

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions