-
Notifications
You must be signed in to change notification settings - Fork 6.6k
[Bug] Detection of existing license headers fails in 0.5.0 #11302
Description
Search before asking
- I had searched in the issues and found no similar issues.
Apache SkyWalking Component
License Tools (apache/skywalking-eyes)
What happened
Once we updated apache/skywalking-eyes/header from v0.4.0 to v0.5.0
typescript and CSS files using a different comment kind than default are no longer detected as having the license and thus incorrectly get a second copy of license header applied.
What you expected to happen
I would expect the existing headers to be detected. I am struggling to see whether this is intended change in the release because it was unpublished (see apache/skywalking-eyes#166 (comment)) and not published again (see https://github.com/apache/skywalking-eyes/releases - if there were release notes warning about breaking changes these are no longer visible)
How to reproduce
This can be seen on jupyterlab/jupyterlab#15068.
For example:
+ /*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
#!/usr/bin/env node
/* -----------------------------------------------------------------------------
| Copyright (c) Jupyter Development Team.
| Distributed under the terms of the Modified BSD License.
|----------------------------------------------------------------------------*/Anything else
No response
Are you willing to submit a pull request to fix on your own?
- Yes I am willing to submit a pull request on my own!
Code of Conduct
- I agree to follow this project's Code of Conduct