-
Notifications
You must be signed in to change notification settings - Fork 193
Variable interpolation section on configuration doc #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bmarwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@weltonrodrigo thanks a lot for your PR! |
Done. |
bdemers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of nits but this is great (and it fills a hole in the docs!!)
|
Thanks @weltonrodrigo !! |
|
Also, we have an update for the |
fpapon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a very useful feature for the docker world, but couldn't find any information about it in the docs. Co-authored-by: Brian Demers <[email protected]>
|
Accepted changes and squashed. |
This is a very useful feature for the docker world, but couldn't find any information about it in the docs.
Also, please note that the footer link "Edit this Page on Github" is pointing to branch
masterinstead of the newmain, this results in a 404 error.