Fix redundant Optional check in DefaultHashService #2088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
Found a redundant Optional check in DefaultHashService class. The current implementation checks if Optional is present (isPresent()) before accessing its value, which is unnecessary as the subsequent method already safely handles null values.
Changes Made
Rationale
This change improves code readability by avoiding unnecessary conditional checks without changing the behavior. Redundant Optional checks make the code more complex and potentially misleading.
Testing
Ran
mvn verifyto ensure basic checks pass. This change does not affect existing functionality, and all tests continue to pass.Contribution Checklist
mvn verifyrun)