[#1879] - ShiroRequestMappingConfig's RequestMappingHandlerMapping dependency annotated with @Qualifier #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Suvrat, Can you please check the licensing box(es) in the PR header, so we can use your work. Thank you. |
2 tasks
Contributor
|
Great, thanks |
Contributor
Contributor
|
We are still waiting for someone to test this fix... |
|
im sorry I dont know what im looking at. does somebody have time to walk me through this in a few weeks? im not sure how to help. im [email protected] or maybe somebody more familiar might be able to help? |
Contributor
|
Thank you Josh. Please look for my email |
1 task
Contributor
|
Thank you very much @joshlong for working and contributing for the fix to this issue! |
lprimak
approved these changes
Jun 17, 2025
10 tasks
Contributor
|
@Suvrat1629 Sorry I mistakenly forced-pushed an empty commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the @qualifier annotation to the RequestMappingHandlerMapping dependency
Fixes #1879
Fixes #1691
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.