Skip to content

Conversation

@lprimak
Copy link
Contributor

@lprimak lprimak commented May 13, 2024

… global SecurityManager

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak added this to the 2.0.1 milestone May 13, 2024
@lprimak lprimak requested a review from bmarwell May 13, 2024 16:52
@lprimak lprimak force-pushed the parallel-core-tests branch 3 times, most recently from a921137 to 8ac9f96 Compare May 13, 2024 17:06
@lprimak lprimak changed the title bugfix(tests): using JUnit's Isolated annotation for tests that touch… bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… May 13, 2024
@lprimak lprimak added core Core Modules tests labels May 13, 2024
@lprimak lprimak force-pushed the parallel-core-tests branch from 8ac9f96 to a1767f7 Compare May 13, 2024 22:24
@lprimak lprimak force-pushed the parallel-core-tests branch 4 times, most recently from d4d0d63 to 8026a24 Compare May 14, 2024 09:44
@lprimak lprimak force-pushed the parallel-core-tests branch from 8026a24 to 13f6c68 Compare May 15, 2024 04:15
@lprimak lprimak requested a review from bmarwell May 15, 2024 04:16
@lprimak lprimak dismissed bmarwell’s stale review May 15, 2024 04:16

All concerning code has been fixed

@lprimak lprimak self-assigned this May 15, 2024
Copy link
Member

@bdemers bdemers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0.9
This is great!
I left a few comments about adding adding a value to the Isolated annotation. suggestions are in there too, but they were added via the GH UI...

This is a non-blocking review 😉

/**
* Unit tests for the {@link org.apache.shiro.config.ogdl.ReflectionBuilder} implementation.
*/
@Isolated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add reason for needing to be isolated (we can possibly fix it in the future)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha Dunno.. cause it failed :)

*
* @since 1.2
*/
@Isolated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add reason

/**
* @since 0.1
*/
@Isolated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add reason

*
* @since May 11, 2010 12:41:38 PM
*/
@Isolated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add reason

*
* @since 1.2
*/
@Isolated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add reason

My guess is that the INI / reflection builder might be sys prop related?

/**
* @since 0.9
*/
@Isolated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add reason

@lprimak lprimak force-pushed the parallel-core-tests branch from 7524f38 to 5c749d4 Compare May 25, 2024 02:39
@lprimak lprimak merged commit 9296467 into apache:main May 25, 2024
@lprimak lprimak deleted the parallel-core-tests branch May 25, 2024 03:01
@lprimak lprimak restored the parallel-core-tests branch May 25, 2024 03:44
@lprimak lprimak deleted the parallel-core-tests branch May 25, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core Modules tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants