Repository navigation
Conversation
2 of 3 tasks
hanzhe-one
added a commit
to hanzhe-one/shenyu
that referenced
this pull request
Oct 30, 2026
Master changed the InstanceCheckService constructor in apache#7971 without updating this fixture, so shenyu-admin test compilation fails and every PR check is blocked. Apply the same fixture change as apache#8247 to unblock CI; it merges cleanly once apache#8247 lands.
This was referenced Oct 30, 2026
Aias00
pushed a commit
that referenced
this pull request
Oct 30, 2026
…#8235) * fix(admin): reject JWTs issued before a password change or revocation Store a per-user token version and embed it in the JWT. A self-service password change, an administrative password reset and an explicit revoke increment the stored version, so a token issued with the previous credential is rejected by ShiroRealm on every Admin instance without rotating the shared signing key. Tokens issued before this change carry no version claim and are treated as version 0, so rolling upgrades keep existing sessions working until the account's version is first incremented. * fix(admin): increment the token version atomically Review follow-up for #8176: the version is now incremented in SQL (token_version = token_version + 1) instead of a read-modify-write, so a delayed password change or revocation cannot write back a stale value and revive a revoked token. The revoke path re-reads the stored row before publishing the audit event, and the full insert/update statements document that they intentionally leave the version alone. * test(admin): pass retention properties to InstanceCheckService Master changed the InstanceCheckService constructor in #7971 without updating this fixture, so shenyu-admin test compilation fails and every PR check is blocked. Apply the same fixture change as #8247 to unblock CI; it merges cleanly once #8247 lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #7971, InstanceCheckService requires InstanceRetentionProperties. The two long-polling liveness fixtures on current master still call the removed one-argument constructor, which makes Admin test compilation fail. Pass the default retention configuration in both fixtures so their existing liveness assertions run with retention disabled.
Validation: the full shenyu-admin Maven reactor (28 modules) passed with 3506 tests, 0 failures, 0 errors and 14 skipped. This includes all 2619 Admin tests and the two affected fixtures. Checkstyle passed as part of the build; a separate
./mvnw -B -ntp -N apache-rat:checkpassed.