Repository navigation
fix(plugin): preserve dynamic candidate matching after cache warmup - #8106
Merged
Merged
Conversation
yangjj-iso
marked this pull request as ready for review
October 26, 2026 03:54
Aias00
approved these changes
Oct 26, 2026
Aias00
left a comment
Contributor
There was a problem hiding this comment.
Approved. This is the correct fix for #7981. getRawPath() now uses the rewritten raw path consistently with matching, and positive caching is gated on every enabled selector/rule being path-determined (the PATH_ONLY_OPERATORS whitelist excludes time predicates such as TimeAfter/TimeBefore and header/query conditions). The 278-line PositiveMatchCacheTest covers header/query/method shadowing, time predicates, and rewritten-URI consistency. Note: #7984 is a duplicate with a correctness gap (it only checks paramType==uri and would still cache TimeAfter/TimeBefore) - recommend closing #7984 in favor of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7981.
A path cache can retain a generic selector or rule and bypass a competing condition that would win for a later request on the same path. Require the entire enabled candidate set to be path-determined before storing a positive result.
Validation on Microsoft OpenJDK 17.0.18 through mvnw.cmd:
Tests use real BaseDataCache, MatchDataCache and matching, Spring mock exchanges, and a controlled clock for time predicates. No deployed gateway or Docker E2E run is claimed. The existing Byte Buddy agent was supplied for local Mockito attachment.