feat:refactor selector reserved keyword fields #6141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved-keyword-fields-selector
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the "selector" table schema to avoid using reserved keywords as column names. The changes rename three problematic fields: "type" → "selector_type", "name" → "selector_name", and "sort" → "sort_code". This improves database compatibility and prevents potential conflicts with SQL reserved keywords.
- Updates database schema across all supported database systems (MySQL, PostgreSQL, Oracle, OceanBase, openGauss)
- Refactors Java entity classes and mappers to use the new field names
- Updates all test cases and service implementations to use the renamed fields
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SelectorDO.java | Updates entity class field names and getter/setter methods |
| selector-sqlmap.xml | Updates MyBatis mapping configuration for new column names |
| schema.sql (various DBs) | Database schema updates for table column renaming |
| upgrade scripts | Database migration scripts for existing deployments |
| Service implementations | Updates to use new field accessors throughout the codebase |
| Test files | Updates test cases to use new field names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Aias00
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat:refactor selector reserved keyword fields. #6137
Change the "type" field in the "selector" table to "selector_type".
Change the "name" field in the "selector" table to "selector_name".
Change the "sort" field in the "selector" table to "sort_code".
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.