improve the function of dubbo plugin configuration based on selector, add registry config. #6096
Conversation
…nfig # Conflicts: # db/init/ob/schema.sql # db/init/og/create-table.sql # db/init/oracle/schema.sql # db/init/pg/create-table.sql
There was a problem hiding this comment.
Pull Request Overview
This PR implements a complete CRUD (Create, Read, Update, Delete) system for registry configuration management as part of the Dubbo plugin enhancement. It adds a new registry_config table and corresponding backend functionality to manage registry information with fields like protocol, address, username, password, namespace, and group.
- Adds new registry_config database table across all supported database systems (MySQL, PostgreSQL, Oracle, OceanBase, OpenGauss)
- Implements complete backend CRUD operations with service layer, controller, and data access components
- Provides REST API endpoints for registry configuration management
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| registry-sqlmap.xml | MyBatis mapper XML defining SQL queries for registry CRUD operations |
| RegistryTransfer.java | Transfer object utility for converting between DO and VO objects |
| RegistryServiceImpl.java | Service implementation providing business logic for registry operations |
| RegistryService.java | Service interface defining registry management operations |
| RegistryVO.java | Value object for API responses |
| RegistryQuery.java | Query object for search and pagination |
| RegistryDO.java | Data object representing registry entity |
| RegistryDTO.java | Data transfer object with validation annotations |
| RegistryMapper.java | MyBatis mapper interface for database operations |
| RegistryController.java | REST controller exposing registry management endpoints |
| http-debug-registry-config-controller-api.http | HTTP test file for API endpoints |
| Database schema files | CREATE TABLE statements and permission setup across all database systems |
Comments suppressed due to low confidence (1)
shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/RegistryServiceImpl.java:1
- In the update operation, the date_created field should not be modified during updates. This field represents the creation time and should remain immutable after initial creation.
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| private String protocol; | ||
|
|
||
| @Length(max = 100, message = "The maximum length is 100") | ||
| @NotNull(message = "address null") |
There was a problem hiding this comment.
The error message 'address null' is incomplete and unclear. It should be 'address cannot be null' or 'address is required' for better user understanding.
| @NotNull(message = "address null") | |
| @NotNull(message = "address cannot be null") |
| private String id; | ||
|
|
||
| @Length(max = 128, message = "The maximum length is 128") | ||
| @NotNull(message = "registry code not null") |
There was a problem hiding this comment.
The error message 'registry code not null' should be 'registry code cannot be null' or 'registry code is required' for grammatical correctness and clarity.
| @NotNull(message = "registry code not null") | |
| @NotNull(message = "registry code is required") |
2 participants
This PR implements a complete CRUD (Create, Read, Update, Delete) system for registry configuration management as part of the Dubbo plugin enhancement task. It adds a new registry_config table and corresponding backend functionality to manage registry information with fields like protocol, address, username, password, namespace, and group.
Table sql schema like follow:
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.