refactor(infra): Refactor ShenYu-Infra module #6082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yuluo-yx
commented
Aug 3, 2025
yuluo-yx
commented
- For [RoadMap] New Plannes for ShenYu 2.7.1 #5923 Refactor ShenYu-Infra module
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
This was referenced Aug 3, 2025
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ShenYu-Infra module to centralize infrastructure-related components, specifically targeting issue #5923. The refactoring aims to consolidate common infrastructure patterns like Redis, Nacos, and Etcd configurations into a unified structure.
- Introduces a new
shenyu-inframodule containing consolidated infrastructure components for Redis, Nacos, and Etcd - Migrates common configuration classes and client implementations from plugin-specific locations to shared infrastructure modules
- Updates dependency references across the codebase to use the new centralized infrastructure modules
Reviewed Changes
Copilot reviewed 82 out of 82 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| shenyu-infra/* | Creates new infrastructure modules for common components (Redis, Nacos, Etcd) with shared configuration and client classes |
| shenyu-plugin/* | Updates Redis-related plugins to use consolidated infrastructure dependencies instead of duplicated implementations |
| shenyu-sync-data-center/* | Migrates Nacos and Etcd sync configurations to use centralized infrastructure modules |
| shenyu-admin-listener/* | Updates admin listeners to reference consolidated infrastructure components |
| pom.xml files | Updates Maven dependencies to reference new infrastructure modules |
Comments suppressed due to low confidence (1)
...infra/shenyu-infra-nacos/src/main/java/org/apache/shenyu/infra/nacos/config/NacosConfig.java
Outdated
Show resolved
Hide resolved
...ra/shenyu-infra-nacos/src/main/java/org/apache/shenyu/infra/nacos/config/NacosACMConfig.java
Outdated
Show resolved
Hide resolved
...yu-infra/shenyu-infra-etcd/src/main/java/org/apache/shenyu/infra/etcd/config/EtcdConfig.java
Outdated
Show resolved
Hide resolved
...yu-infra/shenyu-infra-etcd/src/main/java/org/apache/shenyu/infra/etcd/client/EtcdClient.java
Show resolved
Hide resolved
...in/java/org/apache/shenyu/springboot/starter/sync/data/nacos/NacosSyncDataConfiguration.java
Show resolved
Hide resolved
Signed-off-by: shown.Ji <[email protected]>
Signed-off-by: shown.Ji <[email protected]>
Aias00
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.