[feat] mvnd #6041
[feat] mvnd #6041
Conversation
# Conflicts: # .github/workflows/ci.yml
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Maven Daemon (mvnd) as an alternative build tool to improve CI/CD performance. The changes introduce mvnd installation and usage across multiple GitHub workflow files with fallback to the standard Maven wrapper.
- Installs mvnd version 1.0.2 for both Windows and Linux environments
- Replaces direct Maven wrapper calls with conditional logic to use mvnd when available
- Maintains backward compatibility with Maven wrapper as fallback
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/k8s-examples-http.yml | Adds mvnd installation and conditional usage for Kubernetes HTTP examples build |
| .github/workflows/integrated-test.yml | Integrates mvnd support for integration test builds |
| .github/workflows/integrated-test-k8s-ingress.yml | Adds mvnd support for Kubernetes ingress integration tests |
| .github/workflows/e2e-k8s.yml | Implements mvnd for end-to-end Kubernetes testing workflows |
| .github/workflows/docker-publish.yml | Adds mvnd support for Docker image publishing builds |
| .github/workflows/docker-publish-dockerhub.yml | Integrates mvnd for DockerHub publishing workflow |
| .github/workflows/ci.yml | Adds mvnd installation and verification for main CI pipeline |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - name: Verify mvnd installation | ||
| if: steps.filter.outputs.code == 'true' | ||
| shell: bash | ||
| run: mvnd --version || echo "mvnd version check failed, will use maven wrapper as fallback" |
There was a problem hiding this comment.
The verification step uses || echo which always returns success, making the step appear to pass even when mvnd fails. Consider using a proper error handling approach or removing this step since the build steps already include mvnd availability checks.
| - name: Verify mvnd installation | |
| if: steps.filter.outputs.code == 'true' | |
| shell: bash | |
| run: mvnd --version || echo "mvnd version check failed, will use maven wrapper as fallback" |
| uses: actions/cache/save@v3 | ||
| with: | ||
| path: ~/.m2/repository | ||
| key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }} |
There was a problem hiding this comment.
The restore-keys section was removed from the cache configuration. This could impact cache efficiency as it won't fall back to partial matches when exact cache key isn't found.
3 participants
mvnd
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.