[type:feat] mcp server plugin #5999

Aias00 · 2025-04-08T09:22:38Z

add model context protocol server plugin

Make sure that:

You have read the contribution guidelines.
You submit test cases (unit or integration tests) that back your changes.
Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

# Conflicts: # db/upgrade/2.7.0-upgrade-2.7.1-mysql.sql

…/mcp

# Conflicts: # shenyu-plugin/pom.xml

...cp-server/src/main/java/org/apache/shenyu/plugin/mcp/server/request/RequestConfigHelper.java

moremind · 2025-07-08T14:43:40Z

...cp-server/src/main/java/org/apache/shenyu/plugin/mcp/server/callback/ShenyuToolCallback.java

+    }
+
+    private boolean isRequestBodyMethod(final String method) {
+        return "POST".equalsIgnoreCase(method) || "PUT".equalsIgnoreCase(method) || "PATCH".equalsIgnoreCase(method);


not use magic value

...server/src/main/java/org/apache/shenyu/plugin/mcp/server/holder/ShenyuMcpExchangeHolder.java

...server/src/main/java/org/apache/shenyu/plugin/mcp/server/manager/ShenyuMcpServerManager.java

moremind · 2025-07-08T14:46:15Z

...server/src/main/java/org/apache/shenyu/plugin/mcp/server/manager/ShenyuMcpServerManager.java

+    private ShenyuSseServerTransportProvider createMcpServerTransport(final String uri) {
+        String path = StringUtils.removeEnd(uri, SLASH);
+        LOG.info("Creating new McpServer for URI: {}", path);
+        String messageEndpoint = path + "/message";


same question

...cp-server/src/main/java/org/apache/shenyu/plugin/mcp/server/request/RequestConfigHelper.java

Copilot

Pull Request Overview

This PR introduces a new Model Context Protocol (MCP) server plugin, including its Spring Boot starter, transport layer, session and request management, and database schema updates.

Adds mcp-server plugin modules and auto-configuration for Spring Boot
Implements SSE transport provider, session manager, request/response decorators, and callback integration
Updates database migration scripts and menus to register the new plugin

Reviewed Changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.

File	Description
shenyu-web/src/main/java/org/apache/shenyu/web/filter/FileSizeFilter.java	Reformatted chained method calls for readability
shenyu-spring-boot-starter-plugin-mcp-server/src/main/java/org/apache/shenyu/springboot/starter/plugin/mcp/server/McpServerPluginConfiguration.java	Added MCP plugin beans and auto-configuration imports
shenyu-plugin-mcp-server/src/main/java/org/apache/shenyu/plugin/mcp/server/transport/ShenyuSseServerTransportProvider.java	Implemented SSE transport with session lifecycle management
shenyu-plugin-global/src/main/java/org/apache/shenyu/plugin/global/DefaultShenyuContextBuilder.java	Changed `Optional.ofNullable` to `Optional.of` in HTTP method handling

Copilot · 2025-07-08T14:52:38Z

...ain/java/org/apache/shenyu/plugin/mcp/server/transport/ShenyuSseServerTransportProvider.java

+ */
+public class ShenyuSseServerTransportProvider implements McpServerTransportProvider {
+
+    private static final Logger LOGGER = LoggerFactory.getLogger(WebFluxSseServerTransportProvider.class);


The logger is initialized with the wrong class. It should use ShenyuSseServerTransportProvider.class instead of WebFluxSseServerTransportProvider.class.

Suggested change

private static final Logger LOGGER = LoggerFactory.getLogger(WebFluxSseServerTransportProvider.class);

private static final Logger LOGGER = LoggerFactory.getLogger(ShenyuSseServerTransportProvider.class);

Copilot · 2025-07-08T14:52:38Z

...plugin-global/src/main/java/org/apache/shenyu/plugin/global/DefaultShenyuContextBuilder.java

        shenyuContext.setPath(requestURI.getRawPath());
        shenyuContext.setStartDateTime(LocalDateTime.now());
-        Optional.ofNullable(request.getMethod()).ifPresent(httpMethod -> shenyuContext.setHttpMethod(httpMethod.name()));
+        Optional.of(request.getMethod()).ifPresent(httpMethod -> shenyuContext.setHttpMethod(httpMethod.name()));


Using Optional.of on a potentially null value will throw NPE. It should use Optional.ofNullable to safely handle a null HTTP method.

Suggested change

Optional.of(request.getMethod()).ifPresent(httpMethod -> shenyuContext.setHttpMethod(httpMethod.name()));

Optional.ofNullable(request.getMethod()).ifPresent(httpMethod -> shenyuContext.setHttpMethod(httpMethod.name()));

…henxing/shenyu into feature/import-swagger-url * 'feature/import-swagger-url' of https://github.com/guanzhenxing/shenyu: [type:feat] mcp server plugin (apache#5999)

* [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin, upgrade spring ai version to 1.0.0-M8 * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * [feat] mcp server plugin * feat: mcp server plugin * [feat] mcp server plugin, plugin handle see * [feat] mcp server plugin, some fix * [feat] mcp server plugin, some fix * [feat] mcp server plugin * [feat] mcp server plugin, plugin handle see, toolCallback -> http ok * [feat] mcp server plugin * [feat] mcp server plugin, plugin handle see, toolCallback -> rpc ok * [feat] mcp server plugin, plugin handle see, toolCallback -> rpc ok * [feat] mcp server plugin, tidy up comments * [feat] mcp server plugin, fix some review * [feat] mcp server plugin, fix some review * [feat] mcp server plugin, fix some review * [feat] mcp server plugin, fix some review * [feat] mcp server plugin, fix some review * [feat] mcp server plugin, add messageEndpoint properties * [feat] mcp server plugin, add sql * [feat] mcp server plugin, fix some review * [feat] mcp server plugin, fix check style * [feat] mcp server plugin, fix some review * [feat] mcp server plugin, add messageEndpoint properties --------- Co-authored-by: zhengpeng <[email protected]>

Aias00 added 30 commits April 1, 2025 14:03

[feat] mcp server plugin

8829891

[feat] mcp server plugin

96edd05

[feat] mcp server plugin

712454a

[feat] mcp server plugin

7887436

Merge branch 'refs/heads/master' into feat/mcp

dd5eec8

# Conflicts: # db/upgrade/2.7.0-upgrade-2.7.1-mysql.sql

[feat] mcp server plugin

15da132

[feat] mcp server plugin

d8682c9

[feat] mcp server plugin

7835eee

[feat] mcp server plugin

bfb45ed

[feat] mcp server plugin

60d3d68

[feat] mcp server plugin

fa447ba

[feat] mcp server plugin

4bbd2d1

Merge branch 'master' into feat/mcp

132bd9c

Merge branch 'master' into feat/mcp

0777bc4

Merge branch 'feat/mcp' of https://github.com/Aias00/shenyu into feat…

6646cc6

…/mcp

Merge branch 'master' into feat/mcp

05cc5cf

Merge branch 'feat/mcp' of https://github.com/Aias00/shenyu into feat…

090d099

…/mcp

[feat] mcp server plugin

dcf46da

[feat] mcp server plugin

4a5f8f6

Merge branch 'refs/heads/master' into feat/mcp

9c5edbe

# Conflicts: # shenyu-plugin/pom.xml

[feat] mcp server plugin

dc85e20

[feat] mcp server plugin

5aa9186

[feat] mcp server plugin

667b326

[feat] mcp server plugin

31dc3e6

[feat] mcp server plugin

0e6951c

[feat] mcp server plugin

fc8e3c8

[feat] mcp server plugin

420767e

[feat] mcp server plugin

ff2c02d

[feat] mcp server plugin

60b5dc7

[feat] mcp server plugin

ff3fdc4

Aias00 added 5 commits June 19, 2025 19:37

Merge branch 'master' into feat/mcp

b254cb0

Merge branch 'master' into feat/mcp

222e815

Merge branch 'master' into feat/mcp

0ccf43f

Merge branch 'master' into feat/mcp

0daf878

Merge branch 'master' into feat/mcp

3f3fb82

moremind requested a review from Copilot July 8, 2025 01:50

This comment was marked as outdated.

Sign in to view

moremind requested changes Jul 8, 2025

View reviewed changes

...cp-server/src/main/java/org/apache/shenyu/plugin/mcp/server/request/RequestConfigHelper.java Outdated Show resolved Hide resolved

[feat] mcp server plugin, tidy up comments

28e84b5

moremind requested changes Jul 8, 2025

View reviewed changes

moremind requested a review from Copilot July 8, 2025 14:51

Copilot AI reviewed Jul 8, 2025

View reviewed changes

Aias00 added 11 commits July 9, 2025 10:11

[feat] mcp server plugin, fix some review

8bf9b68

[feat] mcp server plugin, fix some review

f409895

[feat] mcp server plugin, fix some review

aed3dde

[feat] mcp server plugin, fix some review

6773cfd

[feat] mcp server plugin, fix some review

3f71171

[feat] mcp server plugin, add messageEndpoint properties

90d2809

[feat] mcp server plugin, add sql

c18c924

[feat] mcp server plugin, fix some review

990a5d1

[feat] mcp server plugin, fix check style

9b48a4d

[feat] mcp server plugin, fix some review

c5b79cf

[feat] mcp server plugin, add messageEndpoint properties

3888656

moremind approved these changes Jul 15, 2025

View reviewed changes

moremind added this to the 2.7.0.2 milestone Jul 15, 2025

moremind added mcp admin labels Jul 15, 2025

moremind merged commit e2cb6f3 into apache:master Jul 15, 2025
53 of 62 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[type:feat] mcp server plugin #5999

[type:feat] mcp server plugin #5999

Uh oh!

Aias00 commented Apr 8, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

moremind Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

moremind Jul 8, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 8, 2025

Uh oh!

Copilot AI Jul 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	private static final Logger LOGGER = LoggerFactory.getLogger(WebFluxSseServerTransportProvider.class);
	private static final Logger LOGGER = LoggerFactory.getLogger(ShenyuSseServerTransportProvider.class);

	Optional.of(request.getMethod()).ifPresent(httpMethod -> shenyuContext.setHttpMethod(httpMethod.name()));
	Optional.ofNullable(request.getMethod()).ifPresent(httpMethod -> shenyuContext.setHttpMethod(httpMethod.name()));

[type:feat] mcp server plugin #5999

[type:feat] mcp server plugin #5999

Uh oh!

Conversation

Aias00 commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

moremind Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

moremind Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Aias00 commented Apr 8, 2025 •

edited

Loading