[fix] fix ci #5998
Merged
[fix] fix ci #5998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moremind
approved these changes
Apr 12, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
.github/workflows/k8s-examples-http.yml:50
- Commenting out the conditional check causes the 'Install k8s' step to run unconditionally. Please verify that removing this guard is intentional to ensure that steps always execute.
# if: steps.filter.outputs.changed == 'true'
.github/workflows/integrated-test.yml:64
- Disabling the condition for restoring Maven repos could lead to unnecessary cache usage; ensure that running this step unconditionally is as intended for the CI fix.
# if: steps.filter.outputs.changed == 'true'
.github/workflows/integrated-test-k8s-ingress.yml:49
- The conditional check removal here forces the 'Clean Space' step to always run. Confirm that this change will not adversely affect resource management or lead to unintended side effects.
# if: steps.filter.outputs.changed == 'true'
.github/workflows/e2e-k8s.yml:110
- The if condition has been modified to run unconditionally for the repository; please reconfirm that eliminating the change-based trigger for E2E tests aligns with the CI fix objectives.
# if: (github.repository == 'apache/shenyu' && ${{ needs.changes.outputs.e2e == 'true' }})
Member
|
Commenting out the conditional check causes the 'Install k8s' step to run unconditionally. Please verify that removing this guard is intentional to ensure that steps always execute. please check this @Aias00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ci e2e not run
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.