Skip to content

Conversation

@zongmingzhi
Copy link
Contributor

@zongmingzhi zongmingzhi commented Feb 13, 2025

  • Adjust the serialization timing of the request body and response body to avoid unnecessary string operations.
  • Perform string conversion only after confirming the need to record logs to reduce resource consumption.

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

- Adjust the serialization timing of the request body and response body to avoid unnecessary string operations.
- Perform string conversion only after confirming the need to record logs to reduce resource consumption.
@Aias00
Copy link
Contributor

Aias00 commented Feb 13, 2025

hi, Thanks for your contribution. Have you done any comparisons of time consumption/performance? If you have any relevant comparison results, could you please share them?

@zongmingzhi
Copy link
Contributor Author

hi, Thanks for your contribution. Have you done any comparisons of time consumption/performance? If you have any relevant comparison results, could you please share them?

you can conduct simulation tests by yourself. Regarding the problems encountered online, when the concurrency is extremely high, performing the writer.output(); method on data that does not need to be stored leads to frequent fullgc collections, and eventually directly results in an out-of-memory (OOM) error. This optimization has been implemented to resolve the online issues.

@Aias00
Copy link
Contributor

Aias00 commented Feb 13, 2025

hi, Thanks for your contribution. Have you done any comparisons of time consumption/performance? If you have any relevant comparison results, could you please share them?

you can conduct simulation tests by yourself. Regarding the problems encountered online, when the concurrency is extremely high, performing the writer.output(); method on data that does not need to be stored leads to frequent fullgc collections, and eventually directly results in an out-of-memory (OOM) error. This optimization has been implemented to resolve the online issues.

i know what u mean. I just want to say, if there is a comparison, it is better

@Aias00 Aias00 merged commit 5bd78ff into apache:master Feb 13, 2025
44 checks passed
@zongmingzhi
Copy link
Contributor Author

hi, Thanks for your contribution. Have you done any comparisons of time consumption/performance? If you have any relevant comparison results, could you please share them?

you can conduct simulation tests by yourself. Regarding the problems encountered online, when the concurrency is extremely high, performing the writer.output(); method on data that does not need to be stored leads to frequent fullgc collections, and eventually directly results in an out-of-memory (OOM) error. This optimization has been implemented to resolve the online issues.

i know what u mean. I just want to say, if there is a comparison, it is better

thank you for your recognition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants