Skip to content

[type:feat] support alert notice #4782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moremind merged 41 commits into from
Sep 8, 2023
Merged

[type:feat] support alert notice #4782

moremind merged 41 commits into from
Sep 8, 2023

Conversation

@tomsun28
Copy link
Member

@tomsun28 tomsun28 commented Jun 29, 2023

support alert notice design:

  • shenyu admin provider a alarm report api /alert/report to receiver alarm content from gateway pulgin
  • gateway send alert message when them alert trigger
  • shenyu dashboard support manage alert receiver name , alert type(email, dingding, wechat ...)

image

TODO:

  • shenyu admin backend unit test and more
  • a shenyu gateway plugin trigger and send alert to admin
  • relate shenyu dashboard component ui
  • doc and test

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

tomsun28 and others added 20 commits June 26, 2023 11:33
@tomsun28
add dependency
f2b75da
@tomsun28
init alert notice
51d498f
@tomsun28
Merge branch 'master' into feature-alertnotice
a5eac35
@tomsun28
init alert receiver controller api
5125710
@tomsun28
alert notice
b631718
@tomsun28
delete unused alert template
2308295
@tomsun28
Merge branch 'master' into feature-alertnotice
d56252a 
# Conflicts:
#	shenyu-admin/src/main/resources/application-mysql.yml
#	shenyu-admin/src/main/resources/sql-script/h2/schema.sql
@tomsun28
fix pmd error
0cb3b34
@tomsun28
support alarm sender in gateway plugins
f2ee261
@tomsun28
add license header
49cc97e
@tomsun28
Merge branch 'master' into feature-alertnotice
f5ed76d
@tomsun28
pass pmd
6407d4e
@tomsun28
pass pmd
382cb20
@tomsun28
Merge branch 'master' into feature-alertnotice
f65b1a1 
# Conflicts:
#	shenyu-admin/src/main/resources/application-h2.yml
#	shenyu-admin/src/main/resources/application-mysql.yml
#	shenyu-admin/src/main/resources/application-oracle.yml
#	shenyu-admin/src/main/resources/application-pg.yml
@tomsun28
bugfix error typehandler
b12c42d
@tomsun28
bugfix error unit test
2492e28
@tomsun28
fix pmd error
5da4898
@tomsun28
fix pmd error
6f5d6ec
@tomsun28
fix pmd error
5dbfecd
@ywj1352
Merge branch 'master' into feature-alertnotice
d190430
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 9.04110% with 332 lines in your changes missing coverage. Please review.

Project coverage is 61.13%. Comparing base (dcc160f) to head (349c6e9).
Report is 483 commits behind head on master.

Files with missing lines Patch % Lines
...che/shenyu/admin/model/entity/AlertReceiverDO.java 0.00% 84 Missing ⚠️
...u/admin/service/impl/AlertDispatchServiceImpl.java 29.57% 48 Missing and 2 partials ⚠️
...ava/org/apache/shenyu/common/dto/AlarmContent.java 0.00% 44 Missing ⚠️
...u/admin/service/impl/AlertReceiverServiceImpl.java 2.43% 40 Missing ⚠️
...g/apache/shenyu/plugin/base/alert/AlarmSender.java 0.00% 32 Missing ⚠️
...enyu/admin/controller/AlertReceiverController.java 5.88% 16 Missing ⚠️
...che/shenyu/plugin/base/alert/AlarmServiceImpl.java 0.00% 16 Missing ⚠️
...e/shenyu/admin/model/query/AlertReceiverQuery.java 0.00% 15 Missing ⚠️
...nyu/plugin/base/alert/AlarmThreadPoolExecutor.java 0.00% 10 Missing ⚠️
.../org/apache/shenyu/common/config/ShenyuConfig.java 30.76% 9 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #4782      +/-   ##
============================================
- Coverage     61.70%   61.13%   -0.58%     
+ Complexity     8497     8469      -28     
============================================
  Files          1232     1242      +10     
  Lines         36999    37317     +318     
  Branches       3514     3534      +20     
============================================
- Hits          22832    22812      -20     
- Misses        12203    12539     +336     
- Partials       1964     1966       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomsun28
Copy link
Member Author

tomsun28 commented Sep 6, 2023

relate shenyu dashboard pr apache/shenyu-dashboard#333

impactCn
impactCn previously approved these changes Sep 6, 2023
View reviewed changes
@moremind moremind added this to the 2.6.1 milestone Sep 8, 2023
@moremind moremind merged commit 7b97dae into apache:master Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moremind moremind moremind approved these changes

@impactCn impactCn impactCn left review comments

Assignees

No one assigned

Labels

admin feature: metrics

Projects

None yet

Milestone

2.6.1

Development

Successfully merging this pull request may close these issues.

6 participants

@tomsun28 @codecov-commenter @moremind @impactCn @ywj1352 @VampireAchao