You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Task] Update stale matching-cache documentation after Trie removal #7979
The matching-path documentation in AbstractShenyuPlugin.execute still describes an L1 LRU cache followed by an L2 Trie cache and then the default matching strategy. The Trie implementation was removed in commit 295a12bb56539465ba3d979c0e8bbf13b2696fce (PR #6303).
On current master, the rule path checks MatchDataCache and then calls defaultMatchRule on a cache miss. There is no Trie lookup between these steps. The stale comments mislead readers investigating matching behavior or performance.
Requested documentation update
Replace the obsolete L1/L2/Trie comments with the actual flow: bounded match-result cache, then default candidate matching on a miss.
Check maintained matching documentation for the same outdated description and update any remaining references that describe Trie as a current runtime component.
Keep intentional historical references intact.
This is a documentation/comment correction. It does not request restoring Trie, changing matching precedence, or modifying runtime behavior.
PR #7681 (fix(plugin): isolate match cache across config updates) already replaces the stale "L1 LRU / L2 Trie" comments in AbstractShenyuPlugin.execute with a description of the generation-scoped match cache. Its diff touches only AbstractShenyuPlugin, BaseDataCache, CommonPluginDataSubscriber and their tests, so it does not cover any other maintained documentation that may still describe the Trie as a live component.
Should this issue be narrowed to those remaining docs (done after #7681 merges), or closed as covered once the PR lands? I will hold off on a separate change to avoid conflicting with #7681.
Activity
imDwAaY commentedon Oct 22, 2026
/assign
imDwAaY commentedon Oct 22, 2026
PR #7681 (fix(plugin): isolate match cache across config updates) already replaces the stale "L1 LRU / L2 Trie" comments in
AbstractShenyuPlugin.executewith a description of the generation-scoped match cache. Its diff touches onlyAbstractShenyuPlugin,BaseDataCache,CommonPluginDataSubscriberand their tests, so it does not cover any other maintained documentation that may still describe the Trie as a live component.Should this issue be narrowed to those remaining docs (done after #7681 merges), or closed as covered once the PR lands? I will hold off on a separate change to avoid conflicting with #7681.
[ISSUE #7979] update stale matching-cache documentation after trie re…