Skip to content

[Task] Update stale matching-cache documentation after Trie removal #7979

Closed

Description

@Aias00

Problem

The matching-path documentation in AbstractShenyuPlugin.execute still describes an L1 LRU cache followed by an L2 Trie cache and then the default matching strategy. The Trie implementation was removed in commit 295a12bb56539465ba3d979c0e8bbf13b2696fce (PR #6303).

On current master, the rule path checks MatchDataCache and then calls defaultMatchRule on a cache miss. There is no Trie lookup between these steps. The stale comments mislead readers investigating matching behavior or performance.

Requested documentation update

  • Replace the obsolete L1/L2/Trie comments with the actual flow: bounded match-result cache, then default candidate matching on a miss.
  • Check maintained matching documentation for the same outdated description and update any remaining references that describe Trie as a current runtime component.
  • Keep intentional historical references intact.

This is a documentation/comment correction. It does not request restoring Trie, changing matching precedence, or modifying runtime behavior.

References

Acceptance criteria

Current matching-path documentation agrees with the implementation and no longer claims a live L2 Trie lookup. No functional changes are needed.

Searched existing issues for trie comment; no matching documentation task was found.

Activity

  1. imDwAaY commented on Oct 22, 2026

    @imDwAaY
    Contributor

    /assign

  2. imDwAaY commented on Oct 22, 2026

    @imDwAaY
    Contributor

    PR #7681 (fix(plugin): isolate match cache across config updates) already replaces the stale "L1 LRU / L2 Trie" comments in AbstractShenyuPlugin.execute with a description of the generation-scoped match cache. Its diff touches only AbstractShenyuPlugin, BaseDataCache, CommonPluginDataSubscriber and their tests, so it does not cover any other maintained documentation that may still describe the Trie as a live component.

    Should this issue be narrowed to those remaining docs (done after #7681 merges), or closed as covered once the PR lands? I will hold off on a separate change to avoid conflicting with #7681.

  3. added a commit that references this issue on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions