You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(dependencies): move guava out of root <dependencies> into opt-in dependencyManagement #7608
The root pom.xml force-inherits com.google.guava:guava (compile scope) into every reactor module via the top-level <dependencies> block, even modules that never use it.
Evidence
pom.xml:610 opens the root <dependencies> block.
pom.xml:612-620 declares com.google.guava:guava (with com.google.re2j:re2j exclusion) inside that global block, alongside slf4j-api / jcl-over-slf4j / junit-jupiter / junit-vintage.
Guava is the only non-logging / non-test compile dependency globally inherited here; it is not universally required.
Side effect: global inheritance bloats every module's classpath with Guava's (large) transitive tree and masks dependency:analyze "unused declared" warnings for modules that don't actually need it.
Action
Remove the guava <dependency> from root <dependencies> (pom.xml:611-620).
Keep guava centralized in root <dependencyManagement> (pom.xml:329-333) so the version stays managed.
Add an explicit <dependency>com.google.guava:guava</dependency> (version managed) only to the modules that actually import com.google.common.* (typically shenyu-admin, shenyu-common — verify with git grep com.google.common).
Per affected module, run mvn dependency:analyze to confirm no "Used undeclared" regressions after the change.
Acceptance
No module inherits guava unintentionally.
Explicit guava dependencies exist only where used.
Activity
github-actions commentedon Oct 13, 2026
👋 Hello @yuluo-yx
A new issue has been opened by @Aias00:
Please review when you have time. Thank you! 🙏
yangjj-iso commentedon Oct 16, 2026
/assign