Skip to content

[Cleanup] Remove the orphaned shenyu-registry-consul module left behind by the Consul externalization #7583

Closed

Description

@Aias00

Context

PR #7508 externalized Consul support to shenyu-plugin-store (documented in docs/plugin-store-consul.md, which the root README links to) and removed the Consul registry implementation from this repository.

Problem

The module directory shenyu-registry/shenyu-registry-consul was left behind and is now dead, unbuildable code:

  • The directory contains exactly one file: src/test/java/org/apache/shenyu/registry/consul/TtlSchedulerTest.java
  • That test references a TtlScheduler class that no longer exists anywhere in the repository — git grep "class TtlScheduler" HEAD matches only the test file itself — so it cannot compile.
  • The directory has no pom.xml.
  • It is not listed in shenyu-registry/pom.xml's <modules>, which declares only api, core, zookeeper, etcd, nacos, apollo, eureka, kubernetes.

Because the module is not part of any Maven reactor, nothing ever compiles or runs this file, so the breakage is invisible to CI. It only serves to confuse contributors browsing the registry module list, who may conclude that Consul is still a supported in-repo provider.

Suggested fix

Delete the shenyu-registry/shenyu-registry-consul directory (the single test file). No other change is required — the root README already documents Consul as an external plugin-store extension, and no pom.xml references the module.

Verification

$ git ls-tree -r HEAD:shenyu-registry/shenyu-registry-consul
100644 blob 1fec36305d43b6970a20918b9e0b62f2c9bd2413  src/test/java/org/apache/shenyu/registry/consul/TtlSchedulerTest.java

$ git grep -l "class TtlScheduler" HEAD
HEAD:shenyu-registry/shenyu-registry-consul/src/test/java/org/apache/shenyu/registry/consul/TtlSchedulerTest.java

Activity

  1. github-actions commented on Oct 13, 2026

    @github-actions
    Contributor

    👋 Hello @yuluo-yx

    A new issue has been opened by @Aias00:

    Please review when you have time. Thank you! 🙏

  2. Aias00 commented on Oct 13, 2026

    @Aias00
    ContributorAuthor

    Dependency cleanup sub-issues (unit-test / junit-vintage excluded per decision):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions