You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Cleanup] Remove the orphaned shenyu-registry-consul module left behind by the Consul externalization #7583
PR #7508 externalized Consul support to shenyu-plugin-store (documented in docs/plugin-store-consul.md, which the root README links to) and removed the Consul registry implementation from this repository.
Problem
The module directory shenyu-registry/shenyu-registry-consul was left behind and is now dead, unbuildable code:
The directory contains exactly one file: src/test/java/org/apache/shenyu/registry/consul/TtlSchedulerTest.java
That test references a TtlScheduler class that no longer exists anywhere in the repository — git grep "class TtlScheduler" HEAD matches only the test file itself — so it cannot compile.
The directory has no pom.xml.
It is not listed in shenyu-registry/pom.xml's <modules>, which declares only api, core, zookeeper, etcd, nacos, apollo, eureka, kubernetes.
Because the module is not part of any Maven reactor, nothing ever compiles or runs this file, so the breakage is invisible to CI. It only serves to confuse contributors browsing the registry module list, who may conclude that Consul is still a supported in-repo provider.
Suggested fix
Delete the shenyu-registry/shenyu-registry-consul directory (the single test file). No other change is required — the root README already documents Consul as an external plugin-store extension, and no pom.xml references the module.
Activity
github-actions commentedon Oct 13, 2026
👋 Hello @yuluo-yx
A new issue has been opened by @Aias00:
Please review when you have time. Thank you! 🙏
Aias00 commentedon Oct 13, 2026
Dependency cleanup sub-issues (unit-test / junit-vintage excluded per decision):
refactor(registry): remove the orphaned shenyu-registry-consul module (…