You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 86e544b
Browse filesBrowse the repository at this point in the historyBrowse files
Stabilize Sentinel integrated rate-limit assertions (#6374)
The HTTP integrated Sentinel tests used back-to-back requests to prove one successful pass and one rate-limited response. On slow CI, sequential requests can cross Sentinel's one-second QPS window, leaving the expected limited response absent even though the gateway behavior is correct.
This changes the trigger to concurrent requests and asserts over the observed result set, preserving the same behavior coverage while removing timing dependence from the test.
Constraint: Failure appeared in the master push for #6361 in build (shenyu-integrated-test-http), after Sentinel fallback coverage was added.
Rejected: Increase sleeps or timeouts | would make the timing window larger without making the assertion deterministic.
Rejected: Change Sentinel production cleanup | the failing surface is the test trigger timing, and production cleanup changes would broaden risk unnecessarily.
Confidence: medium
Scope-risk: narrow
Directive: Keep Sentinel rate-limit integration assertions concurrency-based; sequential requests can cross QPS windows on loaded runners.
Tested: ./mvnw -f shenyu-integrated-test/pom.xml -pl shenyu-integrated-test-http -am -DskipTests test-compile
Tested: git diff --check
Not-tested: Full Docker integrated-test-http run locally; required CI images and supporting services were not prebuilt locally.
Copy file name to clipboardExpand all lines: shenyu-integrated-test/shenyu-integrated-test-http/src/test/java/org/apache/shenyu/integrated/test/http/combination/SentinelPluginTest.java
0 commit comments