[Fix][Core] Fix the placeholders cannot pass parameters when using complex config #9800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when using multiple tables for reading in JDBC Source
Hisoka-X
reviewed
Aug 31, 2025
| System.getProperty(placeholder), | ||
| null); | ||
| }); | ||
| } else if (variable instanceof Map) { |
Contributor
Author
There was a problem hiding this comment.
I indeed never expected a scenario where a list is nested within another list. If such a case exists, I think I could add another if (variable instanceof List) to recursively call itself
Hisoka-X
changed the title
…hen using complex configurations (including List in List)
Hisoka-X
reviewed
Aug 31, 2025
seatunnel-core/seatunnel-core-starter/src/test/resources/config_complex_nested_variables.conf
Outdated
Show resolved
Hide resolved
Hisoka-X
reviewed
Aug 31, 2025
...nnel-core-starter/src/test/java/org/apache/seatunnel/core/starter/utils/ConfigShadeTest.java
Show resolved
Hide resolved
Hisoka-X
approved these changes
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9797 where placeholders cannot pass parameters when using multiple tables for reading in JDBC Source
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide